Support PHP7 error exceptions everywhere#127
Merged
vladar merged 1 commit intowebonyx:v0.10from Jun 25, 2017
danez:throwable
Merged
Support PHP7 error exceptions everywhere#127vladar merged 1 commit intowebonyx:v0.10from danez:throwable
vladar merged 1 commit intowebonyx:v0.10from
danez:throwable
Conversation
Member
|
I'd really like to accept this PR. Minor breaks are ok for next major version, but this PR breaks every PHP version older than 7.0+. And we must still support previous PHP versions. Can you try running tests on PHP5.6 and fix failures? |
Contributor
Author
|
It was meant to be bc, besides the change of the interface. I had #126 before which broke php <7, this should have been the fixed version. |
Contributor
Author
|
Okay I fixed it. |
Member
|
Thanks! I'll merge it when I start working on next major version |
Member
|
@danez Can you change target branch of this PR from |
Contributor
Author
|
Done |
Also replace \Error with \Throwable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles error exceptions in all places and also replace \Error with \Throwable.
This is a breaking change as the API for the interface PromiseAdapter changes, but otherwise there is now way in catching php7 errors that might happen in the Promise.