Skip to content

Support PHP7 error exceptions everywhere#127

Merged
vladar merged 1 commit intowebonyx:v0.10from
danez:throwable
Jun 25, 2017
Merged

Support PHP7 error exceptions everywhere#127
vladar merged 1 commit intowebonyx:v0.10from
danez:throwable

Conversation

@danez
Copy link
Copy Markdown
Contributor

@danez danez commented Jun 6, 2017

This handles error exceptions in all places and also replace \Error with \Throwable.

This is a breaking change as the API for the interface PromiseAdapter changes, but otherwise there is now way in catching php7 errors that might happen in the Promise.

@vladar
Copy link
Copy Markdown
Member

vladar commented Jun 8, 2017

I'd really like to accept this PR. Minor breaks are ok for next major version, but this PR breaks every PHP version older than 7.0+. And we must still support previous PHP versions. Can you try running tests on PHP5.6 and fix failures?

@danez
Copy link
Copy Markdown
Contributor Author

danez commented Jun 8, 2017

It was meant to be bc, besides the change of the interface. I had #126 before which broke php <7, this should have been the fixed version.
Let me check.

@danez
Copy link
Copy Markdown
Contributor Author

danez commented Jun 8, 2017

Okay I fixed it.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 93.47% when pulling 2a992fa on danez:throwable into e7cde5e on webonyx:master.

@vladar
Copy link
Copy Markdown
Member

vladar commented Jun 9, 2017

Thanks! I'll merge it when I start working on next major version

@vladar
Copy link
Copy Markdown
Member

vladar commented Jun 24, 2017

@danez Can you change target branch of this PR from master to v10.0 ?

@danez danez changed the base branch from master to v0.10 June 25, 2017 14:30
@danez
Copy link
Copy Markdown
Contributor Author

danez commented Jun 25, 2017

Done

Also replace \Error with \Throwable
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 93.447% when pulling 65ef159 on danez:throwable into a0657b7 on webonyx:v0.10.

@vladar vladar merged commit d18cb84 into webonyx:v0.10 Jun 25, 2017
@danez danez deleted the throwable branch June 25, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants