Skip to content

Fix wrong length being used in validator.#292

Merged
vladar merged 1 commit intowebonyx:masterfrom
danez:patch-2
Jun 23, 2018
Merged

Fix wrong length being used in validator.#292
vladar merged 1 commit intowebonyx:masterfrom
danez:patch-2

Conversation

@danez
Copy link
Copy Markdown
Contributor

@danez danez commented Jun 22, 2018

This makes the validator throw currently if the lengths do not match. Seems I copy and pasted it wrong. Comparing to graphql-js it is now the same with this PR.

 [rg\core\base\exceptions\NoticeException]  
Undefined offset: 1                        
                                            

Exception trace:
vendor/composer/webonyx/graphql-php/src/Validator/Rules/OverlappingFieldsCanBeMerged.php:436
GraphQL\Validator\Rules\OverlappingFieldsCanBeMerged->findConflictsBetweenSubSelectionSets() at /vendor/composer/webonyx/graphql-php/src/Validator/Rules/OverlappingFieldsCanBeMerged.php:628

@vladar vladar merged commit 6195029 into webonyx:master Jun 23, 2018
@danez danez deleted the patch-2 branch June 23, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants