Conversation
|
Seet, thanks! But can you please change the target branch from 0.12.x to master? I don't think we'll do much work in 0.12.x branch anymore (just minor fixes). |
| }, | ||
| "config": { | ||
| "bin-dir": "bin", | ||
| "platform": { |
There was a problem hiding this comment.
Remove this to test lib in environment without faking platform.
|
@vladar 0.12 is break for php 7.3 nightly and platform config was hiding this. That the reason why I added this on 0.12 because this helps to fix some issues. |
|
Yeah, but those fixes will stay in 0.12.x, or do you plan to merge them later to master? Master is just quite far away from 0.12.x branch, so there will be lots of conflicts during the merge. |
|
0.12.x should always be merged in master, this is the best way to maintain both branch while 0.12 is still maintained, yes I will merged it in master. |
| }, | ||
| "scripts": { | ||
| "static-analysis": [ | ||
| "rm phpstan.phar || true", |
There was a problem hiding this comment.
why not simply use phpstan as a dev dependency? this looks unnecessarily complicated
There was a problem hiding this comment.
cause phpstan require php 7.1 ;)
There was a problem hiding this comment.
I m not on master ;) but 0.12.x
There was a problem hiding this comment.
Ah, so this can be safely replace with clean dep dependency after rebase onto master, right? #329 (comment)
There was a problem hiding this comment.
Not sure if I understand correctly :D This is how it should look like
https://github.com/doctrine/dbal/blob/master/composer.json#L23
And in travis, simply use script: vendor/bin/phpstan analyse
There was a problem hiding this comment.
This PR is targeting 0.12.x we'll see how to clean it for master when it will be merged. Right now lets just focus on this PR please ;)
| }, | ||
| "scripts": { | ||
| "static-analysis": [ | ||
| "rm phpstan.phar || true", |
There was a problem hiding this comment.
Not sure if I understand correctly :D This is how it should look like
https://github.com/doctrine/dbal/blob/master/composer.json#L23
And in travis, simply use script: vendor/bin/phpstan analyse
|
@vladar can you please review this and tell me if I need to split this in two PR. I need to fix nightly build for the bundle ;) |
|
Thank you I'm working on a PR to merge these changes in master? |
|
Yes, please |
3 participants
Adding some tools to help maintainers.