Skip to content

Fix BC#476

Merged
vladar merged 1 commit intowebonyx:0.13.xfrom
mcg-web:fix-bc
May 11, 2019
Merged

Fix BC#476
vladar merged 1 commit intowebonyx:0.13.xfrom
mcg-web:fix-bc

Conversation

@mcg-web
Copy link
Copy Markdown
Contributor

@mcg-web mcg-web commented May 10, 2019

hi v0.13.2 introduce a BC since changing the signature or a public or a protected method is not allowed in patch releases

@simPod
Copy link
Copy Markdown
Collaborator

simPod commented May 10, 2019

If only it was in docblock before :( :D

@vladar vladar merged commit 58d86ab into webonyx:0.13.x May 11, 2019
@vladar
Copy link
Copy Markdown
Member

vladar commented May 11, 2019

Technically 0.x.x versions are not considered stable and anything can change at any time.

But yeah, we consider our releases stable, so I've merged this. FYI, we will switch to 14.0.0 for the next release (same as the reference implementation).

@mcg-web
Copy link
Copy Markdown
Contributor Author

mcg-web commented May 11, 2019

Thank you for the information, after more than 3 years of usage in production this is more than stable right now 😁.

@serbanbjd
Copy link
Copy Markdown

This fix is breaking maxDepth check, because now in QueryDepth::isEnabled $this->getMaxQueryDepth will return false, and $this->getMaxQueryDepth() !== self::DISABLED will return true

@mcg-web mcg-web deleted the fix-bc branch May 12, 2019 08:50
@mcg-web
Copy link
Copy Markdown
Contributor Author

mcg-web commented May 12, 2019

did not see this change, this line was forced to integer in previous releases since it does not exists anymore maxQueryDepth must be an integer.

@vladar
Copy link
Copy Markdown
Member

vladar commented May 13, 2019

@mcg-web Mind sending another PR for this?

@mcg-web
Copy link
Copy Markdown
Contributor Author

mcg-web commented May 13, 2019

done #477 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants