Scalar type ResolverInfo::getFieldSelection support#529
Merged
vladar merged 12 commits intowebonyx:masterfrom Aug 6, 2019
Merged
Scalar type ResolverInfo::getFieldSelection support#529vladar merged 12 commits intowebonyx:masterfrom
vladar merged 12 commits intowebonyx:masterfrom
Conversation
simPod
requested changes
Aug 6, 2019
Collaborator
simPod
left a comment
simPod
left a comment
There was a problem hiding this comment.
Let's make test more fun and readable and give it some names. But LGTM overall.
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
Contributor
Author
|
Love github mobile. @simPod squash merge this for me? 😇 |
Collaborator
|
@vladar is owner here, let's wait what he has to say on this ;) |
Member
|
Merged. Thanks, guys! |
Contributor
Author
|
Awesome thanks 🙏 can you tag a release? 🚀 |
vladar
pushed a commit
that referenced
this pull request
Aug 7, 2019
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net> (cherry picked from commit e01b6e0)
Member
|
Just published v0.13.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support calling ResolveInfo::getFieldSelection() on scalar types
Related: #528