Skip to content

Handle nullable DirectiveNode#astNode in SchemaValidationContext#708

Merged
vladar merged 2 commits intowebonyx:masterfrom
spawnia:directive-ast-node-nullable
Jul 21, 2020
Merged

Handle nullable DirectiveNode#astNode in SchemaValidationContext#708
vladar merged 2 commits intowebonyx:masterfrom
spawnia:directive-ast-node-nullable

Conversation

@spawnia
Copy link
Copy Markdown
Collaborator

@spawnia spawnia commented Jul 21, 2020

TypeError : Return value of GraphQL\Type\SchemaValidationContext::GraphQL\Type\{closure}() must be an instance of GraphQL\Language\AST\DirectiveDefinitionNode, null returned
 /workdir/vendor/webonyx/graphql-php/src/Type/SchemaValidationContext.php:227
 /workdir/vendor/webonyx/graphql-php/src/Utils/Utils.php:172
 /workdir/vendor/webonyx/graphql-php/src/Type/SchemaValidationContext.php:228
 /workdir/vendor/webonyx/graphql-php/src/Type/SchemaValidationContext.php:154
 /workdir/vendor/webonyx/graphql-php/src/Type/Schema.php:527
 /workdir/vendor/webonyx/graphql-php/src/Type/Schema.php:480
 /workdir/src/Console/ValidateSchemaCommand.php:43

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 21, 2020

Coverage Status

Coverage decreased (-0.006%) to 86.241% when pulling fe13957 on spawnia:directive-ast-node-nullable into c1e9c5e on webonyx:master.

Copy link
Copy Markdown
Member

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vladar vladar merged commit f0bcc74 into webonyx:master Jul 21, 2020
@spawnia spawnia deleted the directive-ast-node-nullable branch July 21, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants