Extract check for unique operation types into separate rule#995
Merged
spawnia merged 7 commits intowebonyx:masterfrom Nov 4, 2021
Merged
Extract check for unique operation types into separate rule#995spawnia merged 7 commits intowebonyx:masterfrom
spawnia merged 7 commits intowebonyx:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
============================================
+ Coverage 94.47% 94.49% +0.02%
Complexity 50 50
============================================
Files 119 120 +1
Lines 9617 9635 +18
============================================
+ Hits 9086 9105 +19
+ Misses 531 530 -1
Continue to review full report at Codecov.
|
spawnia
reviewed
Nov 1, 2021
Collaborator
spawnia
left a comment
spawnia
left a comment
There was a problem hiding this comment.
Looks solid overall, can be micro-optimized a bit
Collaborator
|
Can you add a CHANGELOG entry to mention the introduction of a new rule? |
Contributor
Author
|
@spawnia It's ready. |
spawnia
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
UniqueOperationTypesvalidation rule.Corresponding change in the reference implementation: graphql/graphql-js@9b7a8af