Check ListOfType results is an instance of ArrayAccess instead of ArrayObject #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Executor/Executor.php
Outdated
Member
There was a problem hiding this comment.
Technically, we need to check for Traversable interface here, not ArrayAccess, because all we do later is iterating $result in foreach loop.
Will merge this pull request if you change it to Traversable.
Contributor
Author
|
Yes, updated! |
vladar
added a commit
that referenced
this pull request
Aug 10, 2015
Check ListOfType result is an instance of Traversable instead of ArrayObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow the use of a class implementing the ArrayAccess interface.