port findBreakingChanges #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
November 15, 2017 16:12
|
Awesome! I'll review a bit later and will merge as soon as you finish with tests. Thanks! |
|
So is it ready for review/merge? |
|
Yes
… On Nov 28, 2017, at 12:02 AM, Vladimir Razuvaev ***@***.***> wrote:
So is it ready for review/merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
vladar
reviewed
Nov 28, 2017
| foreach ($oldTypeMap as $typeName => $typeDefinition) { | ||
| if (!isset($newTypeMap[$typeName])) { | ||
| $breakingChanges[] = | ||
| ['type' => self::BREAKING_CHANGE_TYPE_REMOVED, 'description' => "${typeName} was removed."]; |
There was a problem hiding this comment.
Had no idea that ${typeName} is a valid form of variable interpolation in PHP. Cool %)
|
Thanks a lot! Really useful stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #64. cc #169
Porting this was really just mechanical translation - kudos on making it so easy!
WIP because I've only done 1/3 of the tests or so. The rest of the code should be ready for review though, in case we want to get a head start on that.