Skip to content

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Jul 1, 2020

The effect is the same, efficiency is better.

The effect is the same, efficiency is better.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 86.33% when pulling 94eae21 on spawnia:replace-function-calls-with-type-casts into b4142e3 on webonyx:master.

@spawnia
Copy link
Collaborator Author

spawnia commented Jul 1, 2020

Those coverage gains 🥇

Copy link
Collaborator

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there even any valid use case for using these cast functions? Except things like array_map('floatval', $arr) where it makes sense.

@spawnia
Copy link
Collaborator Author

spawnia commented Jul 1, 2020

Is there even any valid use case for using these cast functions? Except things like array_map('floatval', $arr) where it makes sense.

intval() takes a base as its second parameter, but that's about it.

Copy link
Member

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vladar vladar merged commit 9c75f3f into webonyx:master Jul 21, 2020
@spawnia spawnia deleted the replace-function-calls-with-type-casts branch July 21, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants