Skip to content

Conversation

@spawnia
Copy link
Collaborator

@spawnia spawnia commented Aug 24, 2020

I converted Executor and ReferenceExecutor to use native type hints where possible and cleaned up a few mismatched types. Turns out a few of them, if translated 1-1, caused type errors.

Now we can be sure the types are correct and will have an easier time when trying to understand what is happening in the code and when refactoring.

@coveralls
Copy link

coveralls commented Aug 24, 2020

Coverage Status

Coverage decreased (-0.1%) to 86.204% when pulling 79d5c74 on spawnia:executor-types into 4f34309 on webonyx:master.

@shmax
Copy link
Contributor

shmax commented Aug 24, 2020

Pretty keen! 👍

No changes to the baseline file..?

Copy link
Member

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks! 👍

@vladar vladar merged commit 8ee8eec into webonyx:master Sep 16, 2020
@spawnia spawnia deleted the executor-types branch April 15, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants