feat: support custom npm clients (options.npm)
#113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 3 3
Lines 169 169
=======================================
Hits 154 154
Misses 15 15
Continue to review full report at Codecov.
|
michael-ciniawsky
changed the title
options.npm)
michael-ciniawsky
requested review from
alexander-akait,
bebraw,
ericclemmons,
insin and
joshwiens
|
Seems that the project is inactive. Wondering when all the pull request will be merged and the new ver will be published. We are looking forward to it. |
|
also add webpack 3 support in this pr. |
michael-ciniawsky
left a comment
michael-ciniawsky
left a comment
There was a problem hiding this comment.
Sry for the delay, I will land this as soon as possible
package.json
Outdated
| { | ||
| "name": "npm-install-webpack-plugin", | ||
| "version": "4.0.4", | ||
| "version": "4.0.5", |
There was a problem hiding this comment.
Please revert this, it is the maintainer/releaser responsibility to do and we have a standard process for this in place already :)
|
@ericclemmons @insin Any objections against this change ? |
|
@michael-ciniawsky just revert the version number please have a look. |
michael-ciniawsky
added
status: Approved
and removed
priority: 5 (nice to have)
pr_action: Discuss
severity: 4 (inconvenient)
labels
|
@lcxfs1991 Thx |
4 participants
some company has their own npm command with a different name ,like tnpm ,cnpm and so on.