This repository was archived by the owner on May 16, 2025. It is now read-only.
chore(package): update devDependencies && peerDependencies (webpack v2.2.1...3.0.0)
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 3 3
Lines 169 169
=======================================
Hits 154 154
Misses 15 15
Continue to review full report at Codecov.
|
michael-ciniawsky
approved these changes
Jun 20, 2017
| }, | ||
| "peerDependencies": { | ||
| "webpack": "^1.12.0 || ^2.1.0-beta.0 || ^2.1.0" | ||
| "webpack": "^1.0.0 || ^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0" |
Member
There was a problem hiding this comment.
- >= 3.0.0-rc.0?
It's just noise to set beta, rc, next etc imho :)
Collaborator
Author
There was a problem hiding this comment.
Just doing what webpack-defaults does - does it need to be in there @d3viant0ne, given the short run of the RC?
michael-ciniawsky
changed the title
devDependencies && peerDependencies (webpack v2.2.1...3.0.0)
Member
|
@insin This is ready, I suppose ? :) |
michael-ciniawsky
added
semver: Patch
status: Approved
and removed
priority: 2 (urgent)
pr_action: Review
severity: 4 (inconvenient)
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peerDependenciesstring from webpack-defaults