Skip to content
This repository was archived by the owner on May 16, 2025. It is now read-only.

Conversation

@ericclemmons
Copy link
Member

No description provided.

@alexander-akait
Copy link
Member

@greggb
Copy link

greggb commented Aug 15, 2017

Do devDependenices meet peerDependencies? I'm running into the same warning and that is probably the issue.

@greggb
Copy link

greggb commented Aug 17, 2017

@evilebottnawi Was looking into this some more as I'm still having the same issue. I still have the older package.json from before #L54. Even uninstalling and reinstalling didn't update it.

Tried a npm cache clean --force, deleted node_modules, and re-installed. Still shows the old peerdependecy list. Could it be that the version wasn't bumped after this change?

@alexander-akait
Copy link
Member

alexander-akait commented Aug 17, 2017

@greggb oh yep, your are right (https://registry.npmjs.org/ericclemmons/-/npm-install-webpack-plugin-4.0.4.tgz), need patch release.
@ericclemmons friendly ping

@codecov
Copy link

codecov bot commented Aug 17, 2017

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files           3        3           
  Lines         173      173           
=======================================
  Hits          157      157           
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f393f...5d265f2. Read the comment docs.

@ericclemmons ericclemmons merged commit 182f592 into master Aug 17, 2017
@ericclemmons
Copy link
Member

I haven't done a release since moving this repo to webpack-contrib, but give v4.0.5 a shot!

@greggb
Copy link

greggb commented Aug 17, 2017

Worked great, thanks for the quick help.

@michael-ciniawsky michael-ciniawsky deleted the 116-v4.0.5 branch August 17, 2017 14:53
@insin
Copy link
Collaborator

insin commented Aug 17, 2017

I had this in draft for other changes in master since the previous release:

  • Added a quiet option - enabling it will silence npm install output.
  • Check if modules are resolvable from the current working directory instead of checking dependencies and devDependencies in package.json .
    • package.json is now optional - the plugin will no longer create it if it doesn't exist.
    • If package.json exists, the plugin will --save newly-installed dependencies to it as usual.
  • Allow Webpack to attempt to resolve loaders first, as module.resolveLoaders configuration may enable resolving of loaders which aren't resolvable from the current working directory.
  • Added support for Babel presets specified as a [preset, options] array.
  • Added compatibility for Webpack 2 creating resolvers later in the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants