Skip to content
This repository was archived by the owner on May 16, 2025. It is now read-only.

fix(installer): invalid JSON.parse(.babelrc) #49

Merged
merged 1 commit into from
Jun 30, 2017
Merged

fix(installer): invalid JSON.parse(.babelrc) #49

merged 1 commit into from
Jun 30, 2017

Conversation

@Coobaha
Copy link
Contributor

@Coobaha Coobaha commented May 24, 2016

No description provided.

@coveralls
Copy link

coveralls commented May 24, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 92.982% when pulling 19a554c on Coobaha:master into 7649f30 on ericclemmons:master.

@ericclemmons
Copy link
Member

ericclemmons commented May 24, 2016

Whoa, good catch!

@ericclemmons ericclemmons added this to the 4.0.1 milestone May 24, 2016
@ericclemmons ericclemmons self-assigned this May 24, 2016
@ericclemmons ericclemmons removed this from the 4.0.1 milestone Jun 7, 2016
@ericclemmons
Copy link
Member

ericclemmons commented Feb 3, 2017

@insin Thoughts on this?

@insin
Copy link
Collaborator

insin commented Feb 3, 2017

Valid .babelrc files may be invalid JSON, as Babel uses json5 to parse it.

We should do the same.

@michael-ciniawsky michael-ciniawsky changed the title fixes JSON.parse babelrc error fix: invalid JSON.parse(.babelrc) Jun 20, 2017
@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Jun 30, 2017 •
edited
Loading

.babelrc needs to be parsed by json5 parser then and this PR won't fix the issue ?

@jsf-clabot
Copy link

jsf-clabot commented Jun 30, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Coobaha
Copy link
Contributor Author

Coobaha commented Jun 30, 2017

Right, now json5 is used

@codecov
Copy link

codecov bot commented Jun 30, 2017

Codecov Report

Merging #49 into master will decrease coverage by 0.37%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   91.12%   90.75%   -0.38%     
==========================================
  Files           3        3              
  Lines         169      173       +4     
==========================================
+ Hits          154      157       +3     
- Misses         15       16       +1
Impacted Files Coverage Δ
src/installer.js 92.13% <80%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545c73f...d110987. Read the comment docs.

michael-ciniawsky
michael-ciniawsky approved these changes Jun 30, 2017
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Coobaha thx

@michael-ciniawsky michael-ciniawsky merged commit d2f393f into webpack-contrib:master Jun 30, 2017
@michael-ciniawsky michael-ciniawsky changed the title fix: invalid JSON.parse(.babelrc) fix(installer): invalid JSON.parse(.babelrc) Jun 30, 2017
@michael-ciniawsky michael-ciniawsky added this to the 4.1.0 milestone Jun 30, 2017
@michael-ciniawsky michael-ciniawsky modified the milestone: 4.1.0 Aug 17, 2017
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ericclemmons ericclemmons

Labels

semver: Patch status: Approved type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Coobaha @coveralls @ericclemmons @insin @michael-ciniawsky @jsf-clabot