Skip to content
This repository was archived by the owner on Sep 9, 2021. It is now read-only.

feat: add support for ServiceWorker (options.mode) #99

Closed
wants to merge 1 commit into from
Closed

feat: add support for ServiceWorker (options.mode) #99

wants to merge 1 commit into from

Conversation

@michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Oct 14, 2017 •
edited
Loading

@michael-ciniawsky michael-ciniawsky mentioned this pull request Oct 14, 2017
Closed
@michael-ciniawsky michael-ciniawsky force-pushed the feat-mode-service branch 2 times, most recently from f826ddf to b144892 Compare October 14, 2017 11:18
TrySound
TrySound reviewed Oct 14, 2017
View reviewed changes
src/options.json
"type": "string"
},
"mode": {
"type": "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we specify enumeration here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think so will do (need to look it up again first 😛 ). Otherwise needs to throw in the code

@michael-ciniawsky michael-ciniawsky deleted the feat-mode-service branch June 20, 2018 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@TrySound TrySound TrySound left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flag: Needs Tests pr_action: Review priority: 5 (nice to have) semver: Minor status: Needs triage type: Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michael-ciniawsky @TrySound @joshwiens