Skip to content

Conversation

@mweibel
Copy link
Contributor

@mweibel mweibel commented Jan 28, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Wrong docs ;) It's correct in the list of options docs and also in code it's by default false.

Breaking Changes

None.

@jsf-clabot
Copy link

jsf-clabot commented Jan 28, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #890 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          10       10           
  Lines         381      381           
  Branches      109      109           
=======================================
  Hits          379      379           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d45e95...5366357. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #890 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          10       10           
  Lines         381      381           
  Branches      109      109           
=======================================
  Hits          379      379           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d45e95...5366357. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #890 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          10       10           
  Lines         381      381           
  Branches      109      109           
=======================================
  Hits          379      379           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d45e95...5366357. Read the comment docs.

@alexander-akait alexander-akait merged commit 2a2ee7b into webpack:master Jan 28, 2019
@alexander-akait
Copy link
Member

Thanks!

@mweibel mweibel deleted the patch-1 branch January 28, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants