Skip to content

Conversation

@vankop
Copy link
Member

@vankop vankop commented May 31, 2020

No description provided.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #221 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   94.97%   95.14%   +0.17%     
==========================================
  Files          36       37       +1     
  Lines        1333     1360      +27     
==========================================
+ Hits         1266     1294      +28     
+ Misses         67       66       -1     
Impacted Files Coverage Δ
lib/ResultPlugin.js 100.00% <ø> (ø)
lib/ResolverFactory.js 96.02% <100.00%> (+0.08%) ⬆️
lib/RestrictionsPlugin.js 100.00% <100.00%> (ø)
lib/Resolver.js 85.84% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad1fd0...4bce694. Read the comment docs.

@vankop vankop force-pushed the add-restrictions branch from 8895d88 to 0ac8b8f Compare May 31, 2020 22:57
@webpack-bot
Copy link

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@sokra
Copy link
Member

sokra commented Jun 1, 2020

Looks good. Need to review in detail when on computer...

strings in restrictions are treated as directory
@sokra sokra merged commit ff11008 into webpack:master Jun 3, 2020
@sokra
Copy link
Member

sokra commented Jun 3, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants