Skip to content

chore: update readme examples to webpack 2 syntax #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2017
Merged

chore: update readme examples to webpack 2 syntax #110

merged 2 commits into from
Feb 21, 2017

Conversation

@AvraamMavridis
Copy link
Contributor

@AvraamMavridis AvraamMavridis commented Feb 17, 2017

Minor update in the README

michael-ciniawsky
michael-ciniawsky suggested changes Feb 17, 2017
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Could you update the syntax to webpack 2 altogether ? 😛 Thx in advance

README.md Outdated

```js
module: {
loaders: [{
Copy link
Member

@michael-ciniawsky michael-ciniawsky Feb 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loaders => rules

Copy link
Member

@michael-ciniawsky michael-ciniawsky Feb 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loader => use

Copy link
Member

@michael-ciniawsky michael-ciniawsky Feb 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query => options

Copy link
Contributor Author

@AvraamMavridis AvraamMavridis Feb 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@codecov
Copy link

codecov bot commented Feb 17, 2017

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #110   +/-   ##
======================================
  Coverage    96.8%   96.8%           
======================================
  Files           2       2           
  Lines          94      94           
  Branches       17      17           
======================================
  Hits           91      91           
  Misses          3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f337b3e...3e09605. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 17, 2017 •
edited
Loading

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #110   +/-   ##
======================================
  Coverage    96.8%   96.8%           
======================================
  Files           2       2           
  Lines          94      94           
  Branches       17      17           
======================================
  Hits           91      91           
  Misses          3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f337b3e...3e09605. Read the comment docs.

@AvraamMavridis AvraamMavridis changed the title chore: update readme, html -> html-loader chore: update readme examples to webpack 2 syntax Feb 17, 2017
@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Feb 21, 2017 •
edited
Loading

@webpack-contrib/admin-team some merge please :)

cc @d3viant0ne

@joshwiens joshwiens merged commit 7c28052 into webpack:master Feb 21, 2017
@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Feb 21, 2017

@d3viant0ne Thx :)

@AvraamMavridis AvraamMavridis deleted the patch-1 branch February 21, 2017 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@michael-ciniawsky michael-ciniawsky michael-ciniawsky requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AvraamMavridis @michael-ciniawsky @joshwiens