Skip to content

Conversation

@ersachin3112
Copy link
Contributor

@ersachin3112 ersachin3112 commented Nov 28, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

update github action/setup-node

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9bb807) 91.55% compared to head (ab75c41) 91.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files           7        7           
  Lines         604      604           
  Branches      198      198           
=======================================
  Hits          553      553           
  Misses         42       42           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update this on line 80 as well

@snitin315 snitin315 merged commit 35d539d into webpack:master Dec 3, 2023
@ersachin3112 ersachin3112 deleted the update-gha branch February 3, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants