Skip to content

Conversation

@cap-Bernardito
Copy link
Contributor

@cap-Bernardito cap-Bernardito commented Jun 5, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

refactor code

Adds the ability to configure imports through the webpack.config

Fixes #71
Fixes #63
Fixes #61
Fixes #60
Fixes #33
Fixes #29
Fixes #25

Breaking Changes

Yes

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #74 into master will increase coverage by 28.37%.
The diff coverage is 98.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #74       +/-   ##
===========================================
+ Coverage   66.66%   95.04%   +28.37%     
===========================================
  Files           2        3        +1     
  Lines          42      121       +79     
  Branches        9       47       +38     
===========================================
+ Hits           28      115       +87     
+ Misses         13        6        -7     
+ Partials        1        0        -1     
Impacted Files Coverage Δ
src/index.js 77.77% <90.00%> (+7.77%) ⬆️
src/utils.js 100.00% <100.00%> (ø)
src/cjs.js 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754baa8...c19daa4. Read the comment docs.

@cap-Bernardito cap-Bernardito marked this pull request as ready for review June 8, 2020 17:34
@alexander-akait alexander-akait merged commit bef708f into master Jun 11, 2020
@alexander-akait alexander-akait deleted the refactor-code branch June 11, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants