Update README.md #187
Merged
Update README.md #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md to tell user they can specify a custom path in `url`, relative or absolute
|
|
alexander-akait
requested changes
Jun 22, 2018
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Can you add tests for this feature to avoid regressions in future?
Contributor
Author
|
I have add a |
alexander-akait
requested changes
Jun 22, 2018
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Don't modify original tests, please add new, thanks! Also can we use other path to test like /my/own/path/.
Contributor
Author
|
I have add a new test case named simple-publicpath. The result is correct. Thank you for you advice. |
alexander-akait
approved these changes
Jun 25, 2018
alexander-akait
requested review from
joshwiens,
michael-ciniawsky,
ooflorent and
shellscape
shellscape
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md to tell user they can specify a custom path in
url, relative or absoluteThis PR contains a:
Motivation / Use-Case
To help user comprehend the guide.
Breaking Changes
Additional Info