Skip to content

fix: conflict multiple asset error #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 29, 2018
Merged

fix: conflict multiple asset error #194

merged 5 commits into from
Jun 29, 2018

Conversation

unchai
Copy link
Contributor

@unchai unchai commented Jun 28, 2018 •
edited by sokra
Loading

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #190

Breaking Changes

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Jun 28, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sokra
Copy link
Member

sokra commented Jun 28, 2018

A test case would be great

alexander-akait
alexander-akait requested changes Jun 28, 2018
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test and we can merge this 👍

@unchai
Copy link
Contributor Author

unchai commented Jun 28, 2018

@sokra @evilebottnawi
Okay~ I added test code.
And there was some problem webpack mode : 'none', so I fix again.

@sokra
Copy link
Member

sokra commented Jun 28, 2018

After a detailed look I think the original code isn't wrong. It's not incorrect that two chunks produce the same file. It the hash matches webpack should accept it.
So I'll fix webpack/webpack to accept duplicate emits when the hash matches. You can keep the PR open. Once fixed the test is still useful.

@unchai
Copy link
Contributor Author

unchai commented Jun 29, 2018

@sokra That's good either. :)

sokra added a commit to webpack/webpack that referenced this pull request Jun 29, 2018
@sokra
allow emitting to the same filename when hash matches
522b324 
fixes webpack/mini-css-extract-plugin#190
fixes webpack/mini-css-extract-plugin#194
@sokra sokra mentioned this pull request Jun 29, 2018
Merged
@sokra sokra reopened this Jun 29, 2018
@alexander-akait alexander-akait merged commit 1023d22 into webpack:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait requested changes

@sokra sokra sokra approved these changes

@ooflorent ooflorent Awaiting requested review from ooflorent

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conflict multiple asset error

4 participants

@unchai @jsf-clabot @sokra @alexander-akait