Skip to content

Conversation

@michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Aug 6, 2018

Type

  • CI

Issues

  • None

SemVer

  • Patch

@alexander-akait
Copy link
Member

@michael-ciniawsky need investigate x composes-async should compile to the expected result (1023ms)

@michael-ciniawsky
Copy link
Member Author

michael-ciniawsky commented Aug 7, 2018

We ideally should do this is our boilerplate since this will fail for each and every repo, but I would like to eventually overhaul the boilerplate beforehand (simplify it). Yeah the test failure seems to be real, I try to look at it but not familiar with the test here atm :)

@alexander-akait
Copy link
Member

@michael-ciniawsky ping me when you investigate

@alexander-akait
Copy link
Member

Also better use https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/jest.config.js file to with "testEnvironment": "node",. It is allow for future tests switch env (if we need this), more universal way.

@michael-ciniawsky
Copy link
Member Author

I didn't find the correct name in the Jest Docs for adding this to the config file, will update

@michael-ciniawsky michael-ciniawsky changed the title ci(package): run tests in an explicit environment (jest --env node) ci(jest): run tests in an explicit environment Aug 21, 2018
@michael-ciniawsky
Copy link
Member Author

Something is really at odds with the CI, all test pass locally (node >= v10.0.0) and when I run npm lint myself the following doesn't show up for me at all 😕 (only one warning)

 /home/circleci/project/src/index.js
    8:8   error  Replace `·Template,·util:·{·createHash·}·` with `⏎··Template,⏎··util:·{·createHash·},⏎`                                    prettier/prettier
  100:10  error  Replace `{·dependencies:·[dependency]·},·callback` with `⏎····{⏎······dependencies:·[dependency],⏎····},⏎····callback⏎··`  prettier/prettier

@alexander-akait
Copy link
Member

@michael-ciniawsky use prettier

@michael-ciniawsky
Copy link
Member Author

The problem is I don't get anything to fix on my machine 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants