refactor: rename NS to MODULE_TYPE and use a static value
#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
force-pushed
the
refactor/NS
branch
from
bb4d0d5 to
3e291f1
Compare
michael-ciniawsky
requested review from
alexander-akait,
ooflorent and
sokra
ScriptedAlchemy
approved these changes
Sep 7, 2018
Member
ScriptedAlchemy
left a comment
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
I can confirm this works. Did it earlier today to extract-css-chunks-webpack-plugin
ooflorent
approved these changes
Sep 7, 2018
alexander-akait
approved these changes
Sep 7, 2018
michael-ciniawsky
added
status: approved
and removed
pr: review
priority: 4 (nice to have)
severity: 4 (inconvenient)
status: pending
labels
Member
|
@michael-ciniawsky maybe patch release? |
ulivz
pushed a commit
to vuejs/vuepress
that referenced
this pull request
Nov 13, 2018
This is because mini-css-extract-plugin had a internal change at webpack/mini-css-extract-plugin#265 which will cause issue to VuePress.
ulivz
added a commit
to vuejs/vuepress
that referenced
this pull request
Nov 13, 2018
This is because mini-css-extract-plugin had a internal change at webpack/mini-css-extract-plugin#265 which will cause issue to VuePress.
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#263
Typ
Issues
SemVer