docs(readme): add media-query-splitting-plugin (Media Query Plugin)
#269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added short note about media-query-splitting-plugin
|
|
alexander-akait
approved these changes
Sep 10, 2018
Contributor
Author
|
Contributor License Agreement signed |
michael-ciniawsky
changed the title
media-query-splitting-plugin (Media Query Plugin)
michael-ciniawsky
suggested changes
Sep 10, 2018
README.md
Outdated
|
|
||
| If you'd like to extract the media queries from the extracted CSS (so mobile users don't need to load desktop specific CSS anymore) you should use the [media-query-plugin](https://github.com/SassNinja/media-query-plugin). It will take over the filename option of the mini-css-extract-plugin and recognize its generated CSS chunks. | ||
|
|
||
| Or you can use [media-query-splitting-plugin](https://github.com/mike-diamond/media-query-splitting-plugin), it will handle mobile, tablet and desktop styles splitting for each CSS chunk in your bundle without any configuration, just add it to the webpack plugins. |
Member
There was a problem hiding this comment.
Please make the description more generic e.g
- you should use the [media-query-plugin](https://github.com/SassNinja/media-query-plugin) ...
+ you should use one of the following plugins ...
and make a list for the plugins instead
... its generated CSS chunks.
- [Media Query Plugin](media-query-plugin)
- [Media Query Splitting Plugin](media-query-splitting-plugin)
[media-query-plugin]: https://github.com/SassNinja/media-query-plugin
[media-query-splitting-plugin]: https://github.com/mike-diamond/media-query-splitting-plugin
Update after review
michael-ciniawsky
suggested changes
Sep 10, 2018
README.md
Outdated
| ### Media Query Plugin | ||
|
|
||
| If you'd like to extract the media queries from the extracted CSS (so mobile users don't need to load desktop specific CSS anymore) you should use the [media-query-plugin](https://github.com/SassNinja/media-query-plugin). It will take over the filename option of the mini-css-extract-plugin and recognize its generated CSS chunks. | ||
| If you'd like to extract the media queries from the extracted CSS (so mobile users don't need to load desktop or tablet specific CSS anymore) you should use one of the the following plugins: |
Member
There was a problem hiding this comment.
- the the following plugins
+ the following pluginsTypo fix after review
michael-ciniawsky
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added short note about media-query-splitting-plugin
This PR contains a:
Motivation / Use-Case
Breaking Changes
Additional Info