Skip to content

Conversation

sibiraj-s
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Prefer css-minimizer-webpack-plugin to optimize-css-assets-webpack-plugin

Breaking Changes

  • None

Additional Info

  • None

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #624 into master will increase coverage by 17.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #624       +/-   ##
===========================================
+ Coverage   71.12%   88.74%   +17.61%     
===========================================
  Files          10       10               
  Lines         613      613               
  Branches      160      160               
===========================================
+ Hits          436      544      +108     
+ Misses        161       66       -95     
+ Partials       16        3       -13     
Impacted Files Coverage Δ
src/loader.js 90.74% <0.00%> (+8.33%) ⬆️
src/CssModule.js 62.68% <0.00%> (+10.44%) ⬆️
src/index.js 91.52% <0.00%> (+13.13%) ⬆️
src/utils.js 88.46% <0.00%> (+34.61%) ⬆️
src/CssDependency.js 100.00% <0.00%> (+65.62%) ⬆️
src/CssLoadingRuntimeModule.js 96.87% <0.00%> (+96.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a2d5a...dc0be22. Read the comment docs.

@alexander-akait
Copy link
Member

Big thanks!

@alexander-akait alexander-akait merged commit 028b4f2 into webpack:master Oct 16, 2020
@sibiraj-s sibiraj-s deleted the docs branch October 16, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants