Skip to content

Conversation

alexander-akait
Copy link
Member

fixes #563

@alexander-akait alexander-akait requested a review from jhnns June 1, 2018 14:21
@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #575 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage   97.58%   97.61%   +0.03%     
==========================================
  Files           6        6              
  Lines         124      126       +2     
==========================================
+ Hits          121      123       +2     
  Misses          3        3
Impacted Files Coverage Δ
lib/loader.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437450f...9fc8c85. Read the comment docs.

@jhnns
Copy link
Member

jhnns commented Jun 1, 2018

Thanks for the notice. I don't think that we should catch the error at all. In the end, we're just adding "Error loading 'node-sass'" which I don't really find helpful. We should just let the error bubble up.

I've created an alternative PR which just removes the try catch: #576

@alexander-akait
Copy link
Member Author

Close in favor #576

@alexander-akait alexander-akait deleted the issue-563 branch June 1, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: sass-loader requires node-sass >=4 but node-sass is already at v4

2 participants