Skip to content

feat: source map generation depends on the devtool option #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Next
merged 1 commit into from
Aug 23, 2019
Merged

feat: source map generation depends on the devtool option #743

merged 1 commit into from
Aug 23, 2019

Conversation

@alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

For better integration with webpack now we respect devtool option. If you enable source map (for example using source-map) it is enable source map generation, if you use false/eval value source map generation is disabled.

Same logic should be used for css-loader and other loader which potentially generate source map. It is steps for zre configurations

Breaking Changes

Yes, if you don't setup sourceMap option for loader, and use devtool option with any value except false/eval, source map will be generated and vice versa.

Additional Info

No

@alexander-akait alexander-akait merged commit fcea88e into next Aug 23, 2019
@alexander-akait alexander-akait deleted the feat-source-map-generation-depends-on-the-devtool-option branch August 23, 2019 13:56
@codecov
Copy link

codecov bot commented Aug 23, 2019 •
edited
Loading

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

11 similar comments
@codecov
Copy link

codecov bot commented Aug 23, 2019 •
edited
Loading

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019 •
edited
Loading

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019 •
edited
Loading

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019 •
edited
Loading

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

@snyk-bot snyk-bot mentioned this pull request Nov 11, 2019
Open
@vpetersson vpetersson mentioned this pull request Mar 13, 2020
Merged
This was referenced Mar 28, 2020
Closed
Merged
Merged
This was referenced Apr 5, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alexander-akait