Skip to content

fix(package): add webpack >= 4 (peerDependencies) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2018
Merged

fix(package): add webpack >= 4 (peerDependencies) #22

merged 1 commit into from
Feb 26, 2018

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Feb 26, 2018 •
edited by michael-ciniawsky
Loading

@alexander-akait alexander-akait mentioned this pull request Feb 26, 2018
Closed
@codecov
Copy link

codecov bot commented Feb 26, 2018 •
edited
Loading

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #22   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           7     7           
  Lines         372   372           
  Branches       65    65           
====================================
  Misses        326   326           
  Partials       46    46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3ec236...f7231cb. Read the comment docs.

@michael-ciniawsky michael-ciniawsky changed the title fix: peerDependency for webpack >= 4 fix(package): add webpack >= 4 (peerDependencies) Feb 26, 2018
@michael-ciniawsky michael-ciniawsky added this to the 1.1.5 milestone Feb 26, 2018
@michael-ciniawsky michael-ciniawsky merged commit 9345756 into master Feb 26, 2018
@michael-ciniawsky michael-ciniawsky deleted the issue-21 branch February 26, 2018 19:15
@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Feb 26, 2018

Released in v1.1.5 🎉

@michael-ciniawsky michael-ciniawsky removed this from the 1.1.6 milestone Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshwiens joshwiens Awaiting requested review from joshwiens

1 more reviewer

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver: Patch status: Approved type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexander-akait @michael-ciniawsky