Listen end events #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event that the read stream terminates before all of the data has been read, the pipe will send an 'end' event. We should listen for this event and hit the callback with it, instead of hanging forever. Added tests to verify this. Verified the patch fixes the problem by running the tests without the patch, observing that they timeout, then running the tests with the patch and verifying you get an error back.
Attempting to run "npm install" on a new-ish Mac with Node v10.11 fails with a number of node-gyp compilation failures. Installing and using the latest versions of node-sass, nan, and fsevents resolves this failure, as each of those packages resolves the issues that led to problems. Update lodash to v4.17.11 to fix a security warning present in the Travis CI configuration. Add Node 10 to the build matrix so we can test for it. I am nervous about the number of changes to package-lock.json and I am not sure how to mitigate that - apparently NPM 6 changed the way requirements are stored in the file so we'll just have to do this at some point. npm/npm#20434
Member
|
@mistic Looks good, remove |
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
+ Coverage 16.99% 17.26% +0.26%
==========================================
Files 7 7
Lines 353 365 +12
Branches 58 60 +2
==========================================
+ Hits 60 63 +3
- Misses 261 268 +7
- Partials 32 34 +2
Continue to review full report at Codecov.
|
Collaborator
Author
|
@evilebottnawi done |
mistic
force-pushed
the
listen-end-events
branch
from
92a132f to
0d72660
Compare
mistic
changed the title
mistic
changed the title
alexander-akait
approved these changes
Dec 18, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revisit for #36
I just merged the branch present in the mentioned PR, applied the suggested review by @evilebottnawi. I had to rebase and amend the commits in order to proceed with this PR forward.
This is the list of changes on this PR: