Bump and audit dependencies with npm audit fix #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bpack to v4 on example. chore(NA): declare dependencies for example on its own package.json.
Closed
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 12.67% 17.14% +4.46%
==========================================
Files 7 7
Lines 355 350 -5
Branches 61 57 -4
==========================================
+ Hits 45 60 +15
+ Misses 272 259 -13
+ Partials 38 31 -7
Continue to review full report at Codecov.
|
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Good job, need rebase
Collaborator
Author
|
@evilebottnawi rebase applied |
alexander-akait
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to bump the used dependencies for newer version and run
npm audit fixto ensure security standards.jestandbabel-jestare not bumped to the last version as they are not compatible withnode 4.8that we still support. Another PR to drop the support for node 4 is already opened #48CC\ @evilebottnawi