fix(generator): fixed the support of native plugins in add command #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractored the code to fix the error of supporting the native plugin in add-generator. removed the toLowerCase() method, added the logic for more general plugin name from the input
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
misterdev
approved these changes
Jun 4, 2019
anshumanv
approved these changes
Jun 4, 2019
|
@evenstensberg Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
evenstensberg
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code to fix the error of supporting the native plugin in
add-generator. removed the toLowerCase() method, added the logic for
more general plugin name from the input
What kind of change does this PR introduce?
bugfix/refactoring
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
fix #906
fixed support for adding native plugin in add-generator
Does this PR introduce a breaking change?
No
Other information
NA