Skip to content

fix(generator): fixed the support of native plugins in add command #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2019
Merged

fix(generator): fixed the support of native plugins in add command #910

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
123a150
fix(generator): fixed the support of native plugins in add command
anikethsaha Jun 4, 2019
20ff530
chore: formatting
evenstensberg Jun 4, 2019
c01a80b
chore: keep lowercase
evenstensberg Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/generators/add-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,14 @@ export default class AddGenerator extends Generator {
* find the names of each natively plugin and check if it matches
*/
if (action === "plugins") {
let answeredPluginName = answerToAction.actionAnswer;
let isPrefixPresent = /webpack./.test(answeredPluginName);

if (isPrefixPresent) {
answeredPluginName = answeredPluginName.replace("webpack.", "").trim();
} else {
answeredPluginName = answeredPluginName.trim();
}
const pluginExist: string = glob
.sync(["node_modules/webpack/lib/*Plugin.js", "node_modules/webpack/lib/**/*Plugin.js"])
.map(
Expand All @@ -300,7 +308,7 @@ export default class AddGenerator extends Generator {
.pop()
.replace(".js", "")
)
.find((p: string): boolean => p.toLowerCase().indexOf(answerToAction.actionAnswer) >= 0);
.find((p: string): boolean => p.toLowerCase().indexOf(answeredPluginName) >= 0);

if (pluginExist) {
this.configuration.config.item = pluginExist;
Expand All @@ -315,8 +323,7 @@ export default class AddGenerator extends Generator {
.split("/")
.pop()
.replace(".json", "")
.toLowerCase()
.indexOf(answerToAction.actionAnswer) >= 0
.indexOf(answeredPluginName) >= 0
);
if (pluginsSchemaPath) {
const constructorPrefix: string =
Expand Down