Skip to content

Fix typo in the synchronous loader code example #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2018
Merged

Fix typo in the synchronous loader code example #1860

merged 2 commits into from
Mar 5, 2018

Conversation

@loicplaire
Copy link

@loicplaire loicplaire commented Feb 27, 2018

this.callback is called with sourceMaps instead of map.

Fix typo in the synchronous loader code example
bd861de 
`this.callback` was called with `sourceMaps` instead of `map`.
@montogeek
Copy link
Member

montogeek commented Feb 27, 2018

Thanks for the correction!

skipjack
skipjack approved these changes Mar 3, 2018
View reviewed changes
Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@TheDutchCoder TheDutchCoder self-assigned this Mar 5, 2018
@TheDutchCoder TheDutchCoder merged commit 98aba95 into webpack:master Mar 5, 2018
@loicplaire loicplaire deleted the patch-1 branch March 5, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@montogeek montogeek montogeek approved these changes

@skipjack skipjack skipjack approved these changes

Assignees

@TheDutchCoder TheDutchCoder

Labels

API Correction

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@loicplaire @montogeek @skipjack @TheDutchCoder