Skip to content

Fix error with filename + npm package. #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Fix error with filename + npm package. #1886

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b750763
Fix error with filename + npm package.
Zicrael Mar 7, 2018
a9a5d92
Merge branch 'next' into patch-1
Zicrael Mar 7, 2018
5ad3fd7
Merge branch 'next' into patch-1
montogeek Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/content/guides/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ First let's create a directory, initialize npm, [install webpack locally](/guide
``` bash
mkdir webpack-demo && cd webpack-demo
npm init -y
npm install --save-dev webpack
Copy link
Member

@dhruvdutt dhruvdutt Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line. We already show the installation for webpack and webpack-cli in the next line.

npm install webpack webpack-cli --save-dev

npm install webpack webpack-cli --save-dev
```

Expand Down Expand Up @@ -167,14 +168,14 @@ __dist/index.html__
</head>
<body>
- <script src="./src/index.js"></script>
+ <script src="dist/bundle.js"></script>
+ <script src="main.js"></script>
</body>
</html>
```

In this setup, `index.js` explicitly requires `lodash` to be present, and binds it as `_` (no global scope pollution). By stating what dependencies a module needs, webpack can use this information to build a dependency graph. It then uses the graph to generate an optimized bundle where scripts will be executed in the correct order.

With that said, let's run `npx webpack` with our script as the [entry point](/concepts/entry-points) and `bundle.js` as the [output](/concepts/output). The `npx` command, which ships with Node 8.2 or higher, runs the webpack binary (`./node_modules/.bin/webpack`) of the webpack package we installed in the beginning:
With that said, let's run `npx webpack` with our script as the [entry point](/concepts/entry-points) and `main.js` as the [output](/concepts/output). The `npx` command, which ships with Node 8.2 or higher, runs the webpack binary (`./node_modules/.bin/webpack`) of the webpack package we installed in the beginning:

``` bash
npx webpack
Expand All @@ -184,8 +185,8 @@ Version: webpack 4.0.1
Time: 3003ms
Built at: 2018-2-26 22:42:11
Asset Size Chunks Chunk Names
bundle.js 69.6 KiB 0 [emitted] main
Entrypoint main = bundle.js
main.js 69.6 KiB 0 [emitted] main
Entrypoint main = main.js
[1] (webpack)/buildin/module.js 519 bytes {0} [built]
[2] (webpack)/buildin/global.js 509 bytes {0} [built]
[3] ./src/index.js 256 bytes {0} [built]
Expand Down