Skip to content

docs(configuration) Update snippets to comply with webpack v4+ #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2018
Merged

docs(configuration) Update snippets to comply with webpack v4+ #1905

merged 2 commits into from
Mar 27, 2018

Conversation

@EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Mar 11, 2018

  1. dont say that its the simplest configuration because simplest is 0cjs now
  2. update snippets

Fixes #1869

@EugeneHlushko EugeneHlushko changed the base branch from master to next March 11, 2018 12:31
@EugeneHlushko
Copy link
Member Author

EugeneHlushko commented Mar 21, 2018

thank you @sokra 👍

@montogeek montogeek merged commit d6812de into webpack:next Mar 27, 2018
@montogeek
Copy link
Member

montogeek commented Mar 27, 2018

Thanks

@EugeneHlushko EugeneHlushko deleted the docs/update-configuration branch March 27, 2018 07:34
montogeek pushed a commit that referenced this pull request Apr 7, 2018
@dhruvdutt @montogeek
docs(): Merge the next branch (#1993)
9814486 
* docs(guides) Fix error with filename + npm package. (#1886)

1) Webpack as default build to file main.js , not on bundle.js. 
2) Add npm install webpack-cli -D to npm install, If you do not do this console throw next: 
======================================================
The CLI moved into a separate package: webpack-cli.
Please install 'webpack-cli' in addition to webpack itself to use the CLI.
-> When using npm: npm install webpack-cli -D
-> When using yarn: yarn add webpack-cli -D
======================================================
So pls fix this, thank`s.

* docs(guides): Added info for v4 and webpack-cli (#1888)

* docs(configuration) Update snippets to comply with webpack v4+ (#1905)

* docs(configuration) Update snippets to comply with webpack v4+

* Expand mode for more info

* fix(docs) Remove git conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@montogeek montogeek montogeek approved these changes

@sokra sokra sokra approved these changes

+1 more reviewer

@dhruvdutt dhruvdutt dhruvdutt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Concepts Configuration New Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EugeneHlushko @montogeek @sokra @dhruvdutt