Skip to content

Add space above comments #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2018
Merged

Add space above comments #1997

merged 1 commit into from
Apr 9, 2018

Conversation

@renjithspace
Copy link
Contributor

@renjithspace renjithspace commented Apr 8, 2018 •
edited
Loading

For better readability. Most of the WebPack users are beginners. Using spaces above comments will increase readability and helps to catch it quickly.

@renjithspace
Add space above comments
0111ba2 
For better readability. Most of the WebPack users are beginners. Using spaces above comments will increase readability and helps to catch it quickly.
@montogeek
Copy link
Member

montogeek commented Apr 9, 2018

Could you please submit screenshots before and after this change

@renjithspace
Copy link
Contributor Author

renjithspace commented Apr 9, 2018

@montogeek Here is the screenshots of the markdown

Before: https://www.awesomescreenshot.com/image/3284895/9c8460132141098b39192ff3bfa30a21
After: https://www.awesomescreenshot.com/image/3284898/cd2155288f7c02a2745711876feeda5e

@montogeek montogeek merged commit 7339a8f into webpack:master Apr 9, 2018
@montogeek
Copy link
Member

montogeek commented Apr 9, 2018

Thanks!

Munter added a commit that referenced this pull request Apr 9, 2018
@Munter
Merge remote-tracking branch 'origin/master' into fix-hyperlink
613c1c7 
* origin/master:
  docs(configuration) Add space above comments (#1997)
  docs(): Merge the next branch (#1993)
  docs(api): Add -o to command (#1995)
  docs(configuration) Fixed an a/an error in `/configuration/module` (#1990)
  docs(guides) Changing the output file to `main.js` (#1951)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@montogeek montogeek montogeek approved these changes

Assignees

No one assigned

Labels

Configuration UI/UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@renjithspace @montogeek