Skip to content

Conversation

@prondubuisi
Copy link

@prondubuisi prondubuisi commented Dec 8, 2018

This PR attempts to fix issue #2547

@jsf-clabot
Copy link

jsf-clabot commented Dec 8, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@evenstensberg
Copy link
Member

Hey @prondubuisi ! Nice job, we're almost set!

For this PR to work, you will need to create a page for the link you just added. I suggest you looking at where the other plugins are located and create a markdown file there with the documentation for the plugin that you just added. That will fix the issue!

@montogeek

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only adds a link, please add documentation for the plugin

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe you should come up with examples as well as how it would look like using a configuration file. Good job so far! 🤘🏽

@prondubuisi
Copy link
Author

prondubuisi commented Dec 11, 2018 via email

@EugeneHlushko
Copy link
Member

Did you try to use the plugin and see how it works before documenting it @prondubuisi ?

@montogeek
Copy link
Member

@prondubuisi Friendly ping

@prondubuisi
Copy link
Author

@montogeek sorry for the wait, am still on this.

@evenstensberg
Copy link
Member

@prondubuisi you will need to use the plugin and write the documentation a bit more detailed. As @EugeneHlushko says, there is some key things missing here

@montogeek
Copy link
Member

@prondubuisi Friendly ping

@chenxsan chenxsan deleted the branch webpack:master November 7, 2022 12:42
@chenxsan chenxsan closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants