-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
docs: add namedmodulesplugin description (#2547) #2708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add name to contributors
|
|
|
Hey @prondubuisi ! Nice job, we're almost set! For this PR to work, you will need to create a page for the link you just added. I suggest you looking at where the other plugins are located and create a markdown file there with the documentation for the plugin that you just added. That will fix the issue! |
EugeneHlushko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only adds a link, please add documentation for the plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe you should come up with examples as well as how it would look like using a configuration file. Good job so far! 🤘🏽
|
Okay. I was thinking there was zero configuration for this.
…On Tue, Dec 11, 2018, 8:14 AM Even Stensberg ***@***.*** wrote:
***@***.**** requested changes on this pull request.
I think maybe you should come up eith examples as well as how it would
look like using a configuration file. Good job so far! 🤘🏽
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2708 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVRz-Iux3sBnWX_jJQoj19vvpGKxL2GQks5u31tcgaJpZM4ZJz-B>
.
|
|
Did you try to use the plugin and see how it works before documenting it @prondubuisi ? |
|
@prondubuisi Friendly ping |
|
@montogeek sorry for the wait, am still on this. |
|
@prondubuisi you will need to use the plugin and write the documentation a bit more detailed. As @EugeneHlushko says, there is some key things missing here |
|
@prondubuisi Friendly ping |
This PR attempts to fix issue #2547