docs(config,plugins) type updates #3294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready Built with commit 2ecad29 https://deploy-preview-3294--webpackjsorg-netlify.netlify.com |
rishabh3112
reviewed
Sep 24, 2019
Member
rishabh3112
left a comment
rishabh3112
left a comment
There was a problem hiding this comment.
Would be great to have | for union types in docs.
| ## Options | ||
|
|
||
| - `paths` (array): A list of RegExps or absolute paths to directories or files that should be ignored | ||
| - `paths` (`[string, RegExp]`): A list of RegExps or absolute paths to directories or files that should be ignored |
Member
There was a problem hiding this comment.
Suggested change
| - `paths` (`[string, RegExp]`): A list of RegExps or absolute paths to directories or files that should be ignored | |
| - `paths` (`[string | RegExp]`): A list of RegExps or absolute paths to directories or files that should be ignored |
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
We can have a discussion on how to improve it outisde of this pr
This was referenced Jun 26, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert types to the ones defined in contribute section, also spotted missing examples and types in configuration section