New api for DefinePlugin #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

EugeneHlushko merged 9 commits into webpack:master from jeffin143:fix-2314

Aug 20, 2020

Contributor

jeffin143 commented Aug 17, 2020

Reoslve : #2314

Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted.
Make sure your PR complies with the [writer's guide][2].
Review the diff carefully as sometimes this can reveal issues.
Do not abandon your Pull Request: [Stale Pull Requests][3].


          New api for DefinePlugin

9226ff2

vercel bot commented Aug 17, 2020 •

edited

Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/8o50tlcqq
✅ Preview: https://webpack-js-org-git-fork-jeffin143-fix-2314.webpack-docs.vercel.app

vercel bot deployed to Preview

August 17, 2020 13:43

View deployment

chenxsan reviewed

View reviewed changes

src/content/plugins/define-plugin.md Outdated Show resolved Hide resolved

src/content/plugins/define-plugin.md Outdated Show resolved Hide resolved

EugeneHlushko requested changes

View reviewed changes

src/content/plugins/define-plugin.md Outdated Show resolved Hide resolved

src/content/plugins/define-plugin.md Outdated Show resolved Hide resolved

EugeneHlushko added the Plugins label


          improve example

1121b67

vercel bot temporarily deployed to Preview

August 18, 2020 19:27

Inactive


          Merge branch 'master' into fix-2314

0d93559

vercel bot deployed to Preview

August 18, 2020 19:28

View deployment

EugeneHlushko approved these changes

View reviewed changes

Member

EugeneHlushko left a comment

Thank you for starting to document this feature, i will take it from here

EugeneHlushko reviewed

View reviewed changes

src/content/plugins/define-plugin.md Outdated Show resolved Hide resolved


          Update src/content/plugins/define-plugin.md

ad927d9

vercel bot temporarily deployed to Preview

August 20, 2020 19:06

Inactive

EugeneHlushko reviewed

View reviewed changes

src/content/plugins/define-plugin.md Outdated Show resolved Hide resolved


          Update src/content/plugins/define-plugin.md

758971b

vercel bot temporarily deployed to Preview

August 20, 2020 19:07

Inactive

EugeneHlushko reviewed

View reviewed changes

src/content/plugins/define-plugin.md Outdated Show resolved Hide resolved


          Update src/content/plugins/define-plugin.md

995db56

vercel bot deployed to Preview

August 20, 2020 19:07

View deployment

EugeneHlushko reviewed

View reviewed changes

src/content/plugins/define-plugin.md Show resolved Hide resolved


          Update src/content/plugins/define-plugin.md

799a012

vercel bot deployed to Preview

August 20, 2020 19:13

View deployment

EugeneHlushko reviewed

View reviewed changes

src/content/plugins/define-plugin.md Outdated Show resolved Hide resolved


          Update src/content/plugins/define-plugin.md

d79392b

vercel bot deployed to Preview

August 20, 2020 19:18

View deployment

EugeneHlushko reviewed

View reviewed changes

src/content/plugins/define-plugin.md Outdated Show resolved Hide resolved


          Update src/content/plugins/define-plugin.md

f91a607

vercel bot deployed to Preview

August 20, 2020 19:27

View deployment

EugeneHlushko merged commit 31b93ca into webpack:master

Member

EugeneHlushko commented Aug 20, 2020

Thanks!

Member

montogeek commented Aug 25, 2020

@EugeneHlushko Please remember to change the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels