Skip to content

Conversation

@montogeek
Copy link
Member

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/ir0q462m4
✅ Preview: https://webpack-js-org-git-montogeek-patch-1.webpack-docs.vercel.app

"npm": "css-minimizer-webpack-plugin",
"description": "Optimize and minify your CSS using cssnano.",
"maintainer": ""
"maintainer": "cap-Bernardito"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better to use webpack-contrib here, because it supported by multiple developers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, also this should support an array of contributors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok given its not supported lets merge, it was sufficient previously

@EugeneHlushko EugeneHlushko merged commit f65f117 into master Aug 28, 2020
@EugeneHlushko EugeneHlushko deleted the montogeek-patch-1 branch August 28, 2020 15:28
@EugeneHlushko
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants