Skip to content

Conversation

@JerryYuanJ
Copy link
Contributor

Using [string] would make sidebar menu have to string items, so I changed it more literal.

image

change [string] to literal desc "array of string".

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

Using \[string\] would make sidebar menu have to string items, so I changed it more literal.
@jsf-clabot
Copy link

jsf-clabot commented Aug 26, 2020

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Aug 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/pxwyiz4ab
✅ Preview: https://webpack-js-org-git-fork-jerryyuanj-patch-1.webpack-docs.vercel.app

Format string title
@EugeneHlushko EugeneHlushko merged commit 233b1a9 into webpack:master Aug 28, 2020
@EugeneHlushko
Copy link
Member

Great catch, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants