-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
add eslint-webpack-plugin to plugins list #4006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eslint-webpack-plugin to plugins list #4006
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/9oz2sjbrr |
|
CI failed: It seems to be caused by this empty table head in eslint-webpack-plugin's readme: cc @evilebottnawi Any chance we can fix it in eslint-webpack-plugin repository? Just add something non-empty like headers = node.children.map(header => typeof header.children[0] !== 'undefined' ? header.children[0].value : ''); |
|
I've submitted a pull request to fix the empty head problem. But I think we have another choice here as we can remove the deprecated eslint-loader to work around the empty table head problem. |
EugeneHlushko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes lets remove, maybe also stick a redirect on the loader page to plugin page?
|
@chenxsan Feel free to send a fix |
|
ok there is already #4010, nevermind |

CI for pull request #3963 failed now https://travis-ci.org/github/webpack/webpack.js.org/jobs/730802775#L992, it might be a result of the update here webpack-contrib/eslint-loader@fc94b5d because eslint-webpack-plugin is not existed yet in this repository.
BTW, it's wrong to edit the
plugins.jsonorloaders.jsonfile like this, they should be generated bysrc/utils/fetch-package-repos.jsautomatically. But let's fix that later after the webpack 5 branch get merged as there're already multiple manual edits as I found, e.g. #3985, #3903