Skip to content

Conversation

@chenxsan
Copy link
Member

@chenxsan chenxsan commented Sep 28, 2020

CI for pull request #3963 failed now https://travis-ci.org/github/webpack/webpack.js.org/jobs/730802775#L992, it might be a result of the update here webpack-contrib/eslint-loader@fc94b5d because eslint-webpack-plugin is not existed yet in this repository.

BTW, it's wrong to edit the plugins.json or loaders.json file like this, they should be generated by src/utils/fetch-package-repos.js automatically. But let's fix that later after the webpack 5 branch get merged as there're already multiple manual edits as I found, e.g. #3985, #3903

@vercel
Copy link

vercel bot commented Sep 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/9oz2sjbrr
✅ Preview: https://webpack-js-org-git-fork-chenxsan-bugfix-add-eslint-webpa-136e75.webpack-docs.vercel.app

@chenxsan
Copy link
Member Author

CI failed:

ERROR in Error: Module build failed (from ../node_modules/remark-loader/src/index.js):
TypeError: Cannot read property 'contents' of undefined
    at plugins.reduce.use.process (/home/travis/build/webpack/webpack.js.org/node_modules/remark-loader/src/parse.js:30:35)
    at done (/home/travis/build/webpack/webpack.js.org/node_modules/unified/index.js:377:11)
    at next (/home/travis/build/webpack/webpack.js.org/node_modules/trough/index.js:42:9)
    at done (/home/travis/build/webpack/webpack.js.org/node_modules/trough/wrap.js:55:16)
    at done (/home/travis/build/webpack/webpack.js.org/node_modules/unified/index.js:32:7)
    at done (/home/travis/build/webpack/webpack.js.org/node_modules/unified/index.js:306:11)
    at next (/home/travis/build/webpack/webpack.js.org/node_modules/trough/index.js:42:9)
    at done (/home/travis/build/webpack/webpack.js.org/node_modules/trough/wrap.js:55:16)
    at wrapped (/home/travis/build/webpack/webpack.js.org/node_modules/trough/wrap.js:36:14)
    at next (/home/travis/build/webpack/webpack.js.org/node_modules/trough/index.js:57:24)
    at done (/home/travis/build/webpack/webpack.js.org/node_modules/trough/wrap.js:55:16)
    at then (/home/travis/build/webpack/webpack.js.org/node_modules/trough/wrap.js:62:5)

It seems to be caused by this empty table head in eslint-webpack-plugin's readme:

image

cc @evilebottnawi Any chance we can fix it in eslint-webpack-plugin repository? Just add something non-empty like - should be enough. Otherwise we have to fix it in https://github.com/montogeek/remark-responsive-tables/blob/master/src/index.js#L20 with something like below to permit empty head:

headers = node.children.map(header => typeof header.children[0] !== 'undefined' ? header.children[0].value : '');

@chenxsan
Copy link
Member Author

chenxsan commented Sep 28, 2020

I've submitted a pull request to fix the empty head problem. But I think we have another choice here as we can remove the deprecated eslint-loader to work around the empty table head problem.

@chenxsan chenxsan marked this pull request as draft September 28, 2020 05:23
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes lets remove, maybe also stick a redirect on the loader page to plugin page?

@alexander-akait
Copy link
Member

@chenxsan Feel free to send a fix

@EugeneHlushko
Copy link
Member

ok there is already #4010, nevermind

@EugeneHlushko EugeneHlushko merged commit d5e6807 into webpack:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants