Skip to content

Conversation

@behnammodi
Copy link
Contributor

@behnammodi behnammodi commented Jan 31, 2022

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 31, 2022

CLA Signed

The committers are authorized under a signed CLA.

@vercel
Copy link

vercel bot commented Jan 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/DcodrRePztXGUq126hChGDa2tRSJ
✅ Preview: https://webpack-js-org-git-fork-behnammodi-patch-1-webpack-docs.vercel.app

@chenxsan
Copy link
Member

chenxsan commented Feb 3, 2022

Thank you but I think it's not necessary. We have so many package managers like pnpm, etc. other than npm/yarn. Not gonna list them all.

@chenxsan chenxsan closed this Feb 3, 2022
@behnammodi
Copy link
Contributor Author

Thank you, but I think we can have something like this:

const HtmlWebpackPlugin = require('html-webpack-plugin'); //installed via npm or any package managers

Why? because at the first time I read the document I was thinking we have to Install that just by npm

@chenxsan
Copy link
Member

chenxsan commented Feb 4, 2022

Thank you, but I think we can have something like this:

const HtmlWebpackPlugin = require('html-webpack-plugin'); //installed via npm or any package managers

Why? because at the first time I read the document I was thinking we have to Install that just by npm

Or maybe we can just remove the comment to avoid misunderstanding.

@chenxsan chenxsan reopened this Feb 4, 2022
@behnammodi
Copy link
Contributor Author

Thank you, but I think we can have something like this:

const HtmlWebpackPlugin = require('html-webpack-plugin'); //installed via npm or any package managers

Why? because at the first time I read the document I was thinking we have to Install that just by npm

Or maybe we can just remove the comment to avoid misunderstanding.

Good idea, I changed

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@chenxsan chenxsan merged commit 0462e9b into webpack:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants