Skip to content

ci: try webpack cache #6269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 21, 2022
Merged

ci: try webpack cache #6269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8f3f641
ci: try webpack cache
snitin315 Jul 13, 2022
c3b5aed
Update .github/workflows/testing.yml
snitin315 Jul 13, 2022
ecc3a86
Update webpack.prod.mjs
snitin315 Jul 13, 2022
c0e541d
Update package.json
snitin315 Jul 13, 2022
aef54fd
Update testing.yml
snitin315 Jul 15, 2022
c6426fb
Update deploy.yml
snitin315 Jul 15, 2022
5b72ab8
fix: use `webpack.*.mjs`
snitin315 Jul 18, 2022
ee0fc69
fix: cache key
snitin315 Jul 19, 2022
ccc0046
fix: use cache form common config
snitin315 Jul 19, 2022
503eb49
Update deploy.yml
snitin315 Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: yarn

- name: Enable webpack persistent caching
uses: actions/cache@v3
id: build-webpack-persistent-cache
with:
path: node_modules/.cache
key: build-${{ hashFiles('**/webpack.*.mjs') }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |-
build-${{ hashFiles('**/webpack.*.mjs') }}-${{ hashFiles('**/yarn.lock') }}
build-${{ hashFiles('**/webpack.*.mjs') }}-

- run: yarn --frozen-lockfile
- name: Build site
run: yarn build
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,16 @@ jobs:

- run: yarn

- name: Enable webpack persistent caching
uses: actions/cache@v3
id: build-webpack-persistent-cache
with:
path: node_modules/.cache
key: build-${{ hashFiles('**/webpack.*.mjs') }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |-
build-${{ hashFiles('**/webpack.*.mjs') }}-${{ hashFiles('**/yarn.lock') }}
build-${{ hashFiles('**/webpack.*.mjs') }}-

- name: Build site
run: yarn build
env:
Expand All @@ -74,6 +84,16 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Enable webpack persistent caching
uses: actions/cache@v3
id: build-webpack-persistent-cache
with:
path: node_modules/.cache
key: build-${{ hashFiles('**/webpack.*.mjs') }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |-
build-${{ hashFiles('**/webpack.*.mjs') }}-${{ hashFiles('**/yarn.lock') }}
build-${{ hashFiles('**/webpack.*.mjs') }}-

- name: Cypress run
uses: cypress-io/github-action@v4
with:
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@
"cypress:open": "cypress open",
"cypress:run": "cypress run",
"prettier": "prettier --write '**/*.{js,json,jsx,css,scss,md,mdx}'",
"prepare": "husky install"
"prepare": "husky install",
"postinstall": "rimraf ./node_modules/.cache/webpack"
Copy link
Member

@chenxsan chenxsan Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason to clear the cache here?

Copy link
Member Author

@snitin315 snitin315 Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's officially recommended.

},
"lint-staged": {
"*.{js,jsx,md,mdx}": [
Expand Down
2 changes: 1 addition & 1 deletion webpack.common.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default ({ ssg = false }) => ({
buildDependencies: {
config: [__filename],
},
cacheDirectory: path.resolve(__dirname, '.cache/webpack'),
cacheDirectory: path.resolve(__dirname, 'node_modules/.cache/webpack')
},
resolve: {
extensions: ['.js', '.jsx', '.scss'],
Expand Down
5 changes: 0 additions & 5 deletions webpack.prod.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ import ProdAssetsManifest from './src/ProdAssetsManifest.mjs';
export default (env) =>
merge(common(env), {
mode: 'production',
cache: {
buildDependencies: {
config: [__filename],
},
},
entry: {
index: {
import: './index.jsx',
Expand Down
5 changes: 0 additions & 5 deletions webpack.ssg.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ export default (env) =>
name: 'ssg',
mode: 'production',
target: 'node',
cache: {
buildDependencies: {
config: [__filename],
},
},
module: {
parser: {
javascript: {
Expand Down