docs: clean up .js-with-links #6459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/content/api/node.mdx
Outdated
| webpack({}, (err, stats) => { | ||
| if (err || stats.hasErrors()) { | ||
| // [Handle errors here](#error-handling) | ||
| // |
Contributor
There was a problem hiding this comment.
Suggested change
| // |
Contributor
There was a problem hiding this comment.
Just wondering if these empty comments were intentional
Member
Author
There was a problem hiding this comment.
It's a placeholder, guess it makes more sense to use // ....
snitin315
previously approved these changes
Oct 19, 2022
Member
snitin315
left a comment
snitin315
left a comment
There was a problem hiding this comment.
Makes sense to move away from this 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have this
.js-with-linksfrom remark-refractor which would generates links inside code block.Unfortunately it's totally broken at the moment:
I have no idea when and how we broke it, and I have no interest to fix it for two reasons:
it's hard to maintain.
Editors like VSCode won't apply syntax highlighting to such a code block, which means we are on our own when editing the code block.
Hence I would like to take this opportunity to clean up them.