Skip to content

Conversation

@nkxrb
Copy link

@nkxrb nkxrb commented Dec 9, 2024

What kind of change does this PR introduce?
This PR introduces a bugfix to handle compatibility issues with Safari versions below 16, which do not support zero-width assertion regular expressions. It modifies the code to avoid using features like named capture groups or other unsupported constructs.

Did you add tests for your changes?
Yes, tests have been added to ensure the fix works correctly across all affected browser versions, including Safari versions below 16. The tests also validate that the functionality remains unchanged in other environments.

Does this PR introduce a breaking change?
No, this PR does not introduce a breaking change. It ensures backward compatibility by using alternative methods for regular expression handling.

What needs to be documented once your changes are merged?
The documentation should include:

  1. An explanation of the changes made to support older Safari versions.
  2. A note about the limitation of zero-width assertions in Safari below version 16.
  3. Guidance on how users can test for compatibility in their own applications.

bugfix for error:  Invalid regular expression: invalid group specifier name
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 9, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@nkxrb nkxrb changed the title bugfix: replace Regex refactor: replace Regex Dec 17, 2024
@alexander-akait
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants