fix: Right Align Copy Buttons & <btrix-desc-list> vertical width: 100%
#1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All copy buttons on the collection share dialog are now on the right side - Adds a tooltip to tell the user the button opens the link in a new tab
- Allows for better placement of items within the container - Adds horizontal padding to info bars
Shrinks99
added
enhancement
|
Looks reasonable, no strong feelings either way. |
ikreymer
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Collection Share Menu
Archived Item Details
App
The
<btrix-desc-list>component is now set towidth: 100%;when it is vertical to take up the entire width of the parent container instead of the component's content. This should allow for easier placement of items within<btrix-desc-list>using flexbox in other places in the future? Checked all the places where it's used for issues, LMK if this isn't an ideal solution?