Skip to content

Conversation

@tw4l
Copy link
Member

@tw4l tw4l commented Oct 2, 2023

First steps for #1233

Also fixes account settings password reset form to only trigger logged-in event after successful password change, and adds the missing email to the PATCH endpoint call, both of which were causing the password reset form to fail silently.

Password validation can be extended within the UserManager's validate_password method to add or modify requirements.

To test:

  • Log in as admin user and attempt to change password to something shorter than 8 or longer than 64 characters, verify it fails with an error message
  • Log in as admin user and attempt to change password to a password between 8-64 characters, verify it works successfully (log out and log back in to be sure)
  • Invite a new user, go to the invitation link, and try to set a password shorter than 8 or longer than 64 characters, verify it fails with an error message
  • Set a password between 8-64 characters from the user invite link, verify it works successfully (log out and log back in as new user to be sure)

Also ixes account settings password reset form to only trigger
logged-in event after successful password change.

Password validation can be extended within the UserManager's
validate_password method to add or modify requirements.
@tw4l tw4l requested review from SuaYoo and ikreymer October 2, 2023 21:57
@tw4l tw4l marked this pull request as draft October 2, 2023 22:29
@tw4l
Copy link
Member Author

tw4l commented Oct 2, 2023

Need to update some tests and want to add a few new ones, so converting back to draft til those are ready.

@tw4l tw4l force-pushed the issue-1233-pw-validation branch from 57a70c2 to 9e4edeb Compare October 3, 2023 17:02
@tw4l tw4l marked this pull request as ready for review October 3, 2023 19:56
@tw4l
Copy link
Member Author

tw4l commented Oct 3, 2023

Tests added, ready for review

Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start for validation, now have a way of adding additional validation options.

@ikreymer ikreymer merged commit bbdb7f8 into main Oct 4, 2023
@ikreymer ikreymer deleted the issue-1233-pw-validation branch October 4, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants